Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Upgrade go min version to 1.18 #1260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lvjp
Copy link

@lvjp lvjp commented Apr 30, 2023

This will permit to use generics in future merge requests

@peterbourgon
Copy link
Member

Can we actually just make this 1.20 and 1.19?

@alwismt
Copy link

alwismt commented May 5, 2023

What about upgrade to least 1.19

@lvjp
Copy link
Author

lvjp commented May 11, 2023

If we upgrade to 1.19, tests will work correctly but the 1.20 test will fail.

If we upgrade to 1.20, tests will also fail !

@peterbourgon
Copy link
Member

Why do we think these failures are a function of the Go version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants